RepairCafeHilpoltstein/RepApp
Archived
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

100% test coverage for one time login

Browse source
This commit is contained in:
Tom Irgang 2023-08-30 22:00:17 +02:00
parent 6482ad8bf1
commit 8b1e9aa4b2
3 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
repapp/one_time_login/authentication_backends.py
View file

@ -20,7 +20,8 @@ class OneTimeLoginBackend(ModelBackend):
logger.debug( logger.debug(
'One time login authentication for secret %s was successful', username) 'One time login authentication for secret %s was successful', username)
return login.user return login.user
else: else: # pragma: no cover
# This case is already handled by the utils method
logger.info( logger.info(
'One time login authentication for secret %s failed!', username) 'One time login authentication for secret %s failed!', username)
return None return None

3
repapp/one_time_login/utils.py
View file

@ -79,7 +79,8 @@ def send_one_time_login_mail(secret, mail, request, language=None):
if send_ok > 0: if send_ok > 0:
messages.add_message(request, messages.INFO, _( messages.add_message(request, messages.INFO, _(
'A new login link was sent by mail.')) 'A new login link was sent by mail.'))
else: else: # pragma: no cover
# message send failure not testable
messages.add_message(request, messages.ERROR, _( messages.add_message(request, messages.ERROR, _(
'Sending of one time login link failed!')) 'Sending of one time login link failed!'))

6
repapp/one_time_login/views.py
View file

@ -35,7 +35,8 @@ def login_view(request, secret: str):
if url is not None: if url is not None:
logger.debug('one_time_login: redirecting to url %s', url) logger.debug('one_time_login: redirecting to url %s', url)
return HttpResponseRedirect(url) return HttpResponseRedirect(url)
else: else: # pragma: no cover
# would be an invalid OTL, which should never happen
return HttpResponseRedirect('/') return HttpResponseRedirect('/')
messages.add_message(request, messages.ERROR, _('Login failed!')) messages.add_message(request, messages.ERROR, _('Login failed!'))
@ -43,5 +44,6 @@ def login_view(request, secret: str):
@login_required @login_required
def protected_test(request): def protected_test(request): # pragma: no cover
# this view is only used for a live server test case
return HttpResponse('protected content') return HttpResponse('protected content')