diff --git a/repapp/one_time_login/authentication_backends.py b/repapp/one_time_login/authentication_backends.py index cacb458..5129aad 100644 --- a/repapp/one_time_login/authentication_backends.py +++ b/repapp/one_time_login/authentication_backends.py @@ -20,7 +20,8 @@ class OneTimeLoginBackend(ModelBackend): logger.debug( 'One time login authentication for secret %s was successful', username) return login.user - else: + else: # pragma: no cover + # This case is already handled by the utils method logger.info( 'One time login authentication for secret %s failed!', username) return None diff --git a/repapp/one_time_login/utils.py b/repapp/one_time_login/utils.py index 71a612c..d47d147 100644 --- a/repapp/one_time_login/utils.py +++ b/repapp/one_time_login/utils.py @@ -79,7 +79,8 @@ def send_one_time_login_mail(secret, mail, request, language=None): if send_ok > 0: messages.add_message(request, messages.INFO, _( 'A new login link was sent by mail.')) - else: + else: # pragma: no cover + # message send failure not testable messages.add_message(request, messages.ERROR, _( 'Sending of one time login link failed!')) diff --git a/repapp/one_time_login/views.py b/repapp/one_time_login/views.py index 748afe5..d9ecfec 100644 --- a/repapp/one_time_login/views.py +++ b/repapp/one_time_login/views.py @@ -35,7 +35,8 @@ def login_view(request, secret: str): if url is not None: logger.debug('one_time_login: redirecting to url %s', url) return HttpResponseRedirect(url) - else: + else: # pragma: no cover + # would be an invalid OTL, which should never happen return HttpResponseRedirect('/') messages.add_message(request, messages.ERROR, _('Login failed!')) @@ -43,5 +44,6 @@ def login_view(request, secret: str): @login_required -def protected_test(request): +def protected_test(request): # pragma: no cover + # this view is only used for a live server test case return HttpResponse('protected content')